Skip to content

@W-22369351: Mark null_value in Pulse filter schema as nullable#338

Open
anyoung-tableau wants to merge 2 commits into
mainfrom
anyoung/fix-null-value
Open

@W-22369351: Mark null_value in Pulse filter schema as nullable#338
anyoung-tableau wants to merge 2 commits into
mainfrom
anyoung/fix-null-value

Conversation

@anyoung-tableau
Copy link
Copy Markdown
Collaborator

I was testing the list-all-pulse-metric-definitions tool against the techandprod site today and got a schema validation error.

requestId: 7, error: Zodios: Invalid response from endpoint 'get /pulse/definitions'
status: 200 OK
cause:
[
  {
    "code": "invalid_type",
    "expected": "string",
    "received": "null",
    "path": [
      "definitions",
      217,
      "specification",
      "basic_specification",
      "filters",
      0,
      "categorical_values",
      0,
      "null_value"
    ]
...

Copilot AI review requested due to automatic review settings May 5, 2026 18:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Pulse types Zod schema to correctly accept null for null_value in categorical filter values, matching observed Tableau Pulse API responses and preventing runtime schema validation failures in tools like list-all-pulse-metric-definitions.

Changes:

  • Mark null_value in the Pulse filter schema as nullable (while remaining optional).
  • Bump package version from 1.18.9 to 1.18.10 (and align lockfile).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/sdks/tableau/types/pulse.ts Adjusts Pulse filter schema to allow null for null_value in API responses.
package.json Increments package version to 1.18.10.
package-lock.json Updates lockfile version fields to 1.18.10.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/sdks/tableau/types/pulse.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants