@W-22369351: Mark null_value in Pulse filter schema as nullable#338
Open
anyoung-tableau wants to merge 2 commits into
Open
@W-22369351: Mark null_value in Pulse filter schema as nullable#338anyoung-tableau wants to merge 2 commits into
anyoung-tableau wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Pulse types Zod schema to correctly accept null for null_value in categorical filter values, matching observed Tableau Pulse API responses and preventing runtime schema validation failures in tools like list-all-pulse-metric-definitions.
Changes:
- Mark
null_valuein the Pulse filter schema asnullable(while remainingoptional). - Bump package version from
1.18.9to1.18.10(and align lockfile).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/sdks/tableau/types/pulse.ts |
Adjusts Pulse filter schema to allow null for null_value in API responses. |
package.json |
Increments package version to 1.18.10. |
package-lock.json |
Updates lockfile version fields to 1.18.10. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing the
list-all-pulse-metric-definitionstool against the techandprod site today and got a schema validation error.