Fix "Argument #1 ($string) must be of type string, bool given"

[staabm]

make the test-suite pass on windows

before this PR:

$ vendor/bin/phpunit
PHPUnit 10.5.38 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.2.12
Configuration: C:\dvl\Workspace\phpstan-extensions\phpunit.xml

E....                                                               5 / 5 (100%)

Time: 00:01.020, Memory: 86.00 MB

There was 1 error:

1) Symplify\PHPStanExtensions\Tests\ErrorFormatter\SymplifyErrorFormatterTest::testFormatErrors with data set #0 ('Some message', 1, 1, 1, 'C:\dvl\Workspace\phpstan-exte...rt.txt')
TypeError: trim(): Argument #1 ($string) must be of type string, bool given

C:\dvl\Workspace\phpstan-extensions\src\Console\Terminal.php:59
C:\dvl\Workspace\phpstan-extensions\src\Console\Terminal.php:34
C:\dvl\Workspace\phpstan-extensions\src\ErrorFormatter\SymplifyErrorFormatter.php:82
C:\dvl\Workspace\phpstan-extensions\src\ErrorFormatter\SymplifyErrorFormatter.php:113
C:\dvl\Workspace\phpstan-extensions\src\ErrorFormatter\SymplifyErrorFormatter.php:71
C:\dvl\Workspace\phpstan-extensions\src\ErrorFormatter\SymplifyErrorFormatter.php:49
C:\dvl\Workspace\phpstan-extensions\tests\ErrorFormatter\SymplifyErrorFormatterTest.php:28

ERRORS!
Tests: 5, Assertions: 5, Errors: 1.

requires #9

[samsonasik]

@staabm please rebase

[staabm]

done

[TomasVotruba]

LGTM, thank you 👍

[samsonasik]

@TomasVotruba I think new release is needed for latest phpstan 1.x for these 2 packages:

• https://github.com/symplify/phpstan-extensions
• https://github.com/symplify/phpstan-rules

then we can prepare for major phpstan 2.

[TomasVotruba]

@samsonasik Start with Rector without PHPStan extension first. We'll handle extension later, as they have less importance.

[samsonasik]

@TomasVotruba sure, phpstan 2 require php-parser 5 so it will need revisit my old PR:

• Try php-parser:dev-master (5-dev) rectorphp/rector-src#2916

to be reincorporated ;)