Skip to content

fix(jolicode/media-bundle): Fix joli media indentation#1998

Merged
symfony-recipes-bot merged 1 commit into
symfony:mainfrom
loic425:fix-joli-media-indentation
Jun 10, 2026
Merged

fix(jolicode/media-bundle): Fix joli media indentation#1998
symfony-recipes-bot merged 1 commit into
symfony:mainfrom
loic425:fix-joli-media-indentation

Conversation

@loic425

@loic425 loic425 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@loic425 loic425 force-pushed the fix-joli-media-indentation branch from 9209e05 to b90d199 Compare June 10, 2026 09:41
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) June 10, 2026 09:41
@symfony-recipes-bot

symfony-recipes-bot commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1998/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1998/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'jolicode/media-bundle:^0.4'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

jolicode/media-bundle

0.1 vs 0.4
diff --git a/jolicode/media-bundle/0.1/config/packages/joli_media.yaml b/jolicode/media-bundle/0.4/config/packages/joli_media.yaml
index 80cb254c..76490b82 100644
--- a/jolicode/media-bundle/0.1/config/packages/joli_media.yaml
+++ b/jolicode/media-bundle/0.4/config/packages/joli_media.yaml
@@ -1,21 +1,25 @@
+# Uncomment the following lines to enable the Sylius bridge configuration
+#imports:
+#    - { resource: '@JoliMediaSyliusBundle/config/app.php' }
+
 # See the documentation for all available configuration options
 joli_media:
     # Configure a media library below. See the documentation for all available options
     # at https://mediabundle.jolicode.com/getting-started/configuration/#configuration
 
-    # libraries:
-    #     default:
-    #         original:
-    #             flysystem: "filesystem.original.storage"
-    #             url_generator:
-    #                 strategy: folder
-    #                 path: /media/original/
-    #         cache:
-    #             flysystem: "filesystem.cache.storage"
-    #             must_store_when_generating_url: false
-    #             url_generator:
-    #                 strategy: folder
-    #                 path: /media/cache/
+    #libraries:
+    #    default:
+    #        original:
+    #            flysystem: "filesystem.original.storage"
+    #            url_generator:
+    #                strategy: folder
+    #                path: /media/original/
+    #        cache:
+    #            flysystem: "filesystem.cache.storage"
+    #            must_store_when_generating_url: false
+    #            url_generator:
+    #                strategy: folder
+    #                path: /media/cache/
 
     pre_processors:
         - JoliCode\MediaBundle\PreProcessor\ExifRemovalPreProcessor
diff --git a/jolicode/media-bundle/0.1/config/routes/joli_media.yaml b/jolicode/media-bundle/0.4/config/routes/joli_media.yaml
index da01f2dc..83e17376 100644
--- a/jolicode/media-bundle/0.1/config/routes/joli_media.yaml
+++ b/jolicode/media-bundle/0.4/config/routes/joli_media.yaml
@@ -2,11 +2,16 @@ _joli_media:
     resource: "@JoliMediaBundle/config/routes.php"
 
 # Uncomment the following lines to enable the EasyAdmin bridge routes
-# _joli_media_easy_admin:
-#     resource: "@JoliMediaEasyAdminBundle/src/Controller/"
-#     prefix: /admin/media
+#_joli_media_easy_admin:
+#    resource: "@JoliMediaEasyAdminBundle/src/Controller/"
+#    prefix: /admin/media
 
 # Uncomment the following lines to enable the Sonata Admin bridge routes
-# _joli_media_sonata_admin:
-#     resource: "@JoliMediaSonataAdminBundle/src/Controller/"
-#     prefix: /admin/media
+#_joli_media_sonata_admin:
+#    resource: "@JoliMediaSonataAdminBundle/src/Controller/"
+#    prefix: /admin/media
+
+# Uncomment the following lines to enable the Sylius bridge routes
+#_joli_media_sylius_admin:
+#    resource: "@JoliMediaSyliusBundle/src/Admin/Controller/"
+#    prefix: /admin/media

# url_generator:
# strategy: folder
# path: /media/cache/
#libraries:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if fixes the indentation while uncommenting the block with PHPStorm.

@symfony-recipes-bot symfony-recipes-bot merged commit cfad76d into symfony:main Jun 10, 2026
1 of 2 checks passed
@loic425 loic425 deleted the fix-joli-media-indentation branch June 10, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants