Economic cashflow model#2
Open
rebeccamccabe wants to merge 14 commits into
Open
Conversation
rebeccamccabe
commented
Oct 12, 2023
rebeccamccabe
commented
Oct 12, 2023
| @@ -0,0 +1,178 @@ | |||
| { | |||
Contributor
Author
There was a problem hiding this comment.
Line #46. cashflow = [profit_year, profit_year, profit_year, profit_year, profit_year] # i need to make this more flexible to account for varying lifetime
you can do np.full( (lifetime,), profit_year).
Reply via ReviewNB
| @@ -0,0 +1,178 @@ | |||
| { | |||
Contributor
Author
There was a problem hiding this comment.
Line #52. time = np.arange(len(cashflow))
Define time above the for loop, and then loop through time, to avoid redoing a similar calc twice.
Reply via ReviewNB
… data, interpolated dataframes for computation, plotted lmp and npv data
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
rebeccamccabe
force-pushed
the
economic_asl
branch
from
2fb5e15 to
c4f75b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.