Skip to content

Fix multibody reactive control stability check incorrectly marking high-period sea states as unstable#160

Draft
Copilot wants to merge 10 commits into
mainfrom
copilot/fix-dynamics-code-issue
Draft

Fix multibody reactive control stability check incorrectly marking high-period sea states as unstable#160
Copilot wants to merge 10 commits into
mainfrom
copilot/fix-dynamics-code-issue

Conversation

Copilot AI commented Apr 3, 2026

Copy link
Copy Markdown
Contributor
  • Investigate root cause: A_c/B_c capping in MEEM but not WAMIT causes inconsistency
  • Remove A_c/B_c PD capping from get_hydro_coeffs_MEEM.m
  • Add A_c/B_c PD capping in get_dynamic_coeffs.m (after both MEEM and WAMIT if/else) so it applies to both hydro coefficient paths
  • Add regression test hydroCoeffCappingAppliedForWAMIT verifying the energy balance condition is satisfied on the WAMIT path
  • Validated: code review passes, no security issues

Copilot AI and others added 2 commits April 3, 2026 17:57
Agent-Logs-Url: https://github.com/symbiotic-engineering/MDOcean/sessions/909bed13-1e5b-4e22-85ad-37ccf41719f4

Co-authored-by: rebeccamccabe <32020426+rebeccamccabe@users.noreply.github.com>
…c-engineering/MDOcean into copilot/fix-dynamics-code-issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants