Skip to content

[Build] Fix host system query for older CMake.#73001

Merged
drodriguez merged 1 commit into
swiftlang:mainfrom
al45tair:al45tair/fix-for-older-cmake
Apr 12, 2024
Merged

[Build] Fix host system query for older CMake.#73001
drodriguez merged 1 commit into
swiftlang:mainfrom
al45tair:al45tair/fix-for-older-cmake

Conversation

@al45tair

Copy link
Copy Markdown
Contributor

DISTRIB_PRETTY_NAME is only supported on CMake 3.22 and later, but we only require CMake 3.19.6.

`DISTRIB_PRETTY_NAME` is only supported on CMake 3.22 and later, but
we only require CMake 3.19.6.
@al45tair al45tair requested a review from drodriguez April 12, 2024 09:03
@al45tair

Copy link
Copy Markdown
Contributor Author

@swift-ci Please smoke test

@al45tair

Copy link
Copy Markdown
Contributor Author

@futurejones I think this fixes the CMake issue introduced by #72049.

@al45tair al45tair requested a review from etcwilde April 12, 2024 09:17
@futurejones

Copy link
Copy Markdown
Contributor

@al45tair, that looks good.
Thanks.

@drodriguez drodriguez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to avoid the problem for us. Thanks!

@drodriguez drodriguez merged commit 682db94 into swiftlang:main Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants