WiX: Conditionally package LLVM.dll#516
Open
Steelskin wants to merge 2 commits into
Open
Conversation
This adds a new configuration option to conditionally package LLVM.dll. The effort to build LLVM as a DLL on Windows is tracked in swiftlang/swift#85241.
Steelskin
requested review from
compnerd,
etcwilde and
shahmishal
as code owners
Steelskin
changed the title
compnerd
reviewed
Mar 30, 2026
compnerd
left a comment
compnerd
left a comment
Member
There was a problem hiding this comment.
I think that this is fine - we will eventually want to remove this option, but it makes sense to have this as a transition thing.
Contributor
Author
Yes, I intend to eventually remove it. I mostly want to have it around in case we need to revert enabling the DLL build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new configuration option to conditionally package LLVM.dll.
The effort to build LLVM as a DLL on Windows is tracked in swiftlang/swift#85241.