Cap batch partitions by target batch size when files < numTasks#2149
Draft
airspeedswift wants to merge 1 commit into
Draft
Cap batch partitions by target batch size when files < numTasks#2149airspeedswift wants to merge 1 commit into
airspeedswift wants to merge 1 commit into
Conversation
The previous formula `max(numTasks, ceil(numFiles/sizeLimit))` forced at least `numTasks` partitions, which when `numFiles <= numTasks` results in approximately one file per partition and defeats the per-process amortization (TypeConverter, IRGen TypeConverter, deserialized decl/type caches, requirement machine) that batch mode is meant to provide. Cap partition count by `ceil(numFiles / preferredBatchSize)` when that yields a smaller value than `numTasks`, so small modules get fewer, larger batches that can share per-process state across files.
airspeedswift
force-pushed
the
batch-partition-target-size
branch
from
e187a46 to
586fd9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous formula
max(numTasks, ceil(numFiles/sizeLimit))forced at leastnumTaskspartitions, which whennumFiles <= numTasksresults in approximately one file per partition and defeats the per-process amortization (TypeConverter, IRGen TypeConverter, deserialized decl/type caches, requirement machine) that batch mode is meant to provide.Cap partition count by
ceil(numFiles / preferredBatchSize)when that yields a smaller value thannumTasks, so small modules get fewer, larger batches that can share per-process state across files.