[NFC] Correctly implement sharedLibraryName for all platforms#2122
Merged
cachemeifyoucan merged 1 commit intoApr 15, 2026
Merged
Conversation
`sharedLibraryName` wasn't provide the correct naming convention for Windows platform, even it is in WindowsExtensions.swift. Now fix the implementation so `sharedLibraryName` can be used to get the name of the shared library with the same name passed for all platforms.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test windows platform |
jakepetroules
approved these changes
Apr 15, 2026
Contributor
Author
|
@swift-ci please test windows platform |
artemcm
approved these changes
Apr 15, 2026
nkcsgexi
approved these changes
Apr 15, 2026
cachemeifyoucan
enabled auto-merge
April 15, 2026 20:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation:
sharedLibraryNamewasn't provide the correct naming convention for Windows platform, even it is in WindowsExtensions.swift. Now fix the implementation sosharedLibraryNamecan be used to get the name of the shared library with the same name passed for all platforms.Scope: NFC change.
Risk: Low. NFC change.