Retry priors file write with exponential backoff#2121
Merged
cachemeifyoucan merged 1 commit intoApr 15, 2026
Conversation
cachemeifyoucan
force-pushed
the
eng/PR-priors-file-backoff
branch
from
April 14, 2026 20:48
c28c52a to
5084a98
Compare
Contributor
Author
|
@swift-ci please test |
cachemeifyoucan
force-pushed
the
eng/PR-priors-file-backoff
branch
from
April 14, 2026 22:07
5084a98 to
d4cc893
Compare
Contributor
Author
|
@swift-ci please test |
owenv
reviewed
Apr 14, 2026
cachemeifyoucan
force-pushed
the
eng/PR-priors-file-backoff
branch
from
April 14, 2026 22:36
d4cc893 to
2168a4c
Compare
Contributor
Author
|
@swift-ci please test |
owenv
approved these changes
Apr 14, 2026
On Windows, atomic file writes (temp file + rename) can fail intermittently with ERROR_ACCESS_DENIED if updates to the file happens really close to the write of the file underload. This can especially happen to `.priors` file in a tight rebuild loop. Now writes `.priors` file in a retry loop with exponential back off. Assisted-By: Claude
cachemeifyoucan
force-pushed
the
eng/PR-priors-file-backoff
branch
from
April 14, 2026 22:45
2168a4c to
8c7d946
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test windows platform |
artemcm
approved these changes
Apr 15, 2026
nkcsgexi
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, atomic file writes (temp file + rename) can fail intermittently with ERROR_ACCESS_DENIED if updates to the file happens really close to the write of the file underload.
This can especially happen to
.priorsfile in a tight rebuild loop. Now writes.priorsfile in a retry loop with exponential back off.Assisted-By: Claude