SwiftDriver: always pass -sysroot flag if specified#2120
Merged
Conversation
artemcm
approved these changes
Apr 14, 2026
artemcm
left a comment
artemcm
left a comment
Contributor
There was a problem hiding this comment.
Would be nice to have a small test for forwarding this flag to a swift-frontend invocation. I don't see any at all in our test suite.
jakepetroules
approved these changes
Apr 15, 2026
This allows passing the flag on all targets. This is primarily to ensure that the flag is properly handled on foreign targets (i.e. Windows) when cross-compiling.
Member
Author
Seems reasonable, added. |
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please test Windows platform |
artemcm
approved these changes
Apr 21, 2026
compnerd
enabled auto-merge (rebase)
April 27, 2026 15:39
nkcsgexi
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows passing the flag on all targets. This is primarily to ensure that the flag is properly handled on foreign targets (i.e. Windows) when cross-compiling.
-sysrooton non-Unix toolchain drivers-sysrootflags as well