[windows][lldb] reduce Docker image size#566
Merged
shahmishal merged 1 commit intoJun 9, 2026
Merged
Conversation
charles-zablit
requested review from
justice-adams-apple and
shahmishal
as code owners
compnerd
reviewed
Jun 3, 2026
| C:\\vcpkg\\bootstrap-vcpkg.bat -disableMetrics | ||
| SHELL ["cmd", "/S", "/C"] | ||
| RUN ""C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvars64.bat" && C:\vcpkg\vcpkg install libxml2:x64-windows" | ||
| RUN ""C:\Program Files\Microsoft Visual Studio\2022\BuildTools\VC\Auxiliary\Build\vcvars64.bat" && C:\vcpkg\vcpkg install libxml2:x64-windows" |
Member
There was a problem hiding this comment.
Why do we need this at all? We build libxml2 from source for the toolchain, we should just do that here and avoid vcpkg entire.
Contributor
Author
There was a problem hiding this comment.
We could yes. I'm not able to test this at desk, so I wanted to minimize the changes to avoid any breakage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch reduces the resulting image size:
vs_community.exetovs_buildtools.exe: Build Tools is headless, no IDE.--depth 1on vcpkg clone to avoid fetching the full git history.vcpkgbuildtrees, packages, downloads after the libxml2 install.Overall, this should reduce the image size from 9GB to ~1GB.