removes logic duplicated in SymbolKit#1091
Closed
heckj wants to merge 2 commits into
Closed
Conversation
heckj
force-pushed
the
duplicate-logic
branch
2 times, most recently
from
92fc12e to
74059be
Compare
Contributor
|
@swift-ci please test |
Kyle-Ye
approved these changes
Nov 17, 2024
Kyle-Ye
left a comment
Kyle-Ye
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Waiting for the symbolkit PR and other's suggestion before a merge.
heckj
force-pushed
the
duplicate-logic
branch
from
74059be to
9fa5bab
Compare
Member
Author
|
(rebased, but otherwise no changes in that last commit) |
Contributor
|
@swift-ci test |
franklinsch
approved these changes
Feb 3, 2025
franklinsch
reviewed
Feb 3, 2025
| let isMainSymbolGraph = !url.lastPathComponent.contains("@") | ||
|
|
||
| let moduleName: String | ||
| if isMainSymbolGraph || symbolGraph.module.bystanders != nil { |
Contributor
There was a problem hiding this comment.
Hmm, I see that this version has a symbolGraph.module.bystanders != nil check, but the SymbolKit version doesn't. Do we need it? cc @QuietMisdreavus
- prefer SymbolKit for this logic
heckj
force-pushed
the
duplicate-logic
branch
from
9fa5bab to
df2fb86
Compare
Member
Author
|
@swift-ci test |
Member
Author
|
closing in favor of #1286 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging #1084, I found this duplicate logic (and the source of the issue). There's an open pull request to resolve the error in SymbolKit (swiftlang/swift-docc-symbolkit#89), and this compliments that pull request to resolve #1084, using the logic in SymbolKit over duplicate, local logic.
I opted for SymbolKit's implementation in this case because its method is public, while the local method was private.