Remove nil default values from primary content section.#1083
Draft
sofiaromorales wants to merge 1 commit into
Draft
Remove nil default values from primary content section.#1083sofiaromorales wants to merge 1 commit into
nil default values from primary content section.#1083sofiaromorales wants to merge 1 commit into
Conversation
The enconder for primary content section now checks for nil values inside the collection, when before it weas checking for empty arrays, causing issues when calculating the index for the replace patcher. rdar://139195428
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 139195428
Summary
The encoder for the primary content section now checks for nil values within the collection, instead of just checking for empty arrays. Previously, this led to issues when calculating the index for the replace patcher.
Dependencies
Describe any dependencies this PR might have, such as an associated branch in another repository.
Testing
Describe how a reviewer can test the functionality of your PR. Provide test content to test with if
applicable.
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded