close mobile navigator, when clicking on any navigation item#364
Open
dobromir-hristov wants to merge 3 commits into
Open
Conversation
marinaaisa
approved these changes
Jul 6, 2023
marinaaisa
requested changes
Jul 6, 2023
marinaaisa
left a comment
marinaaisa
left a comment
Member
There was a problem hiding this comment.
I approved it before but afterwards I realised that it's affecting the desktop experience as well . It should only affect mobile users. Thanks and sorry for the confusion!
added 2 commits
July 12, 2023 11:30
…clicking-current-page # Conflicts: # tests/unit/components/Navigator/NavigatorCard.spec.js
Contributor
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 90839759
Summary
Closes the mobile navigator, if clicked on the already highlighted current page, even though no page navigation is performed.
Dependencies
NA
Testing
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded