[Regression] Fix @Links layout rendering for grid styles#1021
Open
mportiz08 wants to merge 1 commit into
Open
Conversation
@Topics layout rendering for grid styles@Links layout rendering for grid styles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 179413082
Summary
#1018 introduces a regression for the way that columns are rendered within the
@LinksDocC directive when the visual style is eithercompactGridordetailedGrid.This happens because the new
align-itemsproperty has a default offlex-start, which has unintended consequences for the way that theTopicsLinkCardGridcomponent composes theColumncomponent without setting an explicit alignment.By changing the default value from
flex-starttonormal, we can fix the unexpected rendering for the@Linksdirective without impacting the new enhancement to support the alignment property for@Column.Testing
Steps:
@PageImageand@Links(visualStyle: detailedGrid)@Column(alignment: leading|center|trailing)still renders with the expected alignment for its items as implemented in Add support for optional alignment property on row columns #1018Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded