Plugins: install DLL to bin, import library to lib

[compnerd]

Adjust the install rules to account for the different installation expectations on Windows. DLL files are installed into the bin and import libraries are to be installed in lib.

[compnerd]

@swift-ci please test

[ahoppen]

We only use these libraries using LoadLibraryW, should it still be installed to bin? Also, in case you didn’t, could you check that we pick up the plugin from the new installation location by checking if we still receive code completion results with the SourceKit plugin in the new location?

[compnerd]

We only use these libraries using LoadLibraryW, should it still be installed to bin? Also, in case you didn’t, could you check that we pick up the plugin from the new installation location by checking if we still receive code completion results with the SourceKit plugin in the new location?

Well, all the DLLs are meant to be in bin. It really doesn't matter how you use them. That said, it seems that the installer still put them into bin, just did so in the installer.

This PR is paired with swiftlang/swift-installer-scripts#485 and you will see that only the source is changed, not the destination.

[ahoppen]

Thanks for the clarification. Looks good to me 👍🏽

[compnerd]

@swift-ci please test Windows platform

[compnerd]

@swift-ci please test Windows platform

[compnerd]

@swift-ci please test Windows platform

[rintaro]

swiftlang/swift-installer-scripts#485
@swift-ci Please test Windows

[compnerd]

I wonder if CI is setting SOURCEKIT_LSP_TEST_PLUGIN_PATHS