Keep line breaks quoted when serializing CSV fields - #145
Open
rupayon123 wants to merge 1 commit into
Open
rupayon123 wants to merge 1 commit into
rupayon123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serializing a parsed quoted field containing a line break currently removes its quotes when it contains no delimiter or quote character. Reading that output splits a data value into extra rows or changes the header. Quote any field containing the parser's recognized line breaks (LF, CR or CRLF), preserving the existing delimiter/quote escaping behavior.
Two new public-API round-trip tests fail with 42 assertions before the fix. All 44 Swift package tests pass after it. Coverage includes headers and data, named/enumerated views, all three line-break forms, comma/semicolon/tab/custom delimiters. Scoped SwiftLint reports only a pre-existing double-blank-line warning at Serializer.swift:22; the changed code has no new lint findings.
git diff --checkpasses. This is macOS host validation, not an iOS/device or full Xcode platform matrix result.Prepared with AI assistance; the serializer, parser's newline definition and public round-trip behavior were reviewed.