Buildtoacr 01082024#114
Open
hartou wants to merge 50 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a variety of changes to improve the deployment process, configuration, and infrastructure setup. The most important changes include adding parameters to the deployment script for flexibility, adding environment variables to the configuration file, and updating the infrastructure file to create a container app environment.
Deployment and configuration improvements:
deploy_infra.ps1: Added parameters to the deployment script for flexibility and easier customization..env.example: Added new environment variables to the configuration file for various configurations.Infrastructure and deployment automation:
.github/workflows/workflow.yaml: Added a new workflow file that triggers on a push event and performs an Azure login using OIDC, useful for subsequent actions using the Azure CLI.workflows/buildwithacr.yaml: Added a new workflow file that automates the build and deployment of Docker images using an Azure Container Registry.infra/main.bicep: Updated the infrastructure file to add parameters, variables, and resources for creating a container app environment.Other important changes:
pom.xml: Updated the version of the Jackson library to potentially incorporate new features or bug fixes..dockerignore: Addedtarget/directory to exclude build artifacts from Docker image.