feat(style): support CSS attribute selector operators in includesAttrSelector#2201
Open
roli-lpci wants to merge 1 commit into
Open
feat(style): support CSS attribute selector operators in includesAttrSelector#2201roli-lpci wants to merge 1 commit into
roli-lpci wants to merge 1 commit into
Conversation
…Selector Previously, `includesAttrSelector` only checked if an attribute name was referenced in a CSS selector, ignoring the selector's operator and value. This caused SVGO to conservatively keep attributes even when the CSS selector would not actually match the element's attribute value. Add a new `attrValue` parameter that, when provided, evaluates the CSS attribute selector operator (`=`, `^=`, `$=`, `*=`, `~=`, `|=`, exists) against the element's actual attribute value. This allows plugins to safely remove attributes when the selector would not match. Updated call sites in `removeUnknownsAndDefaults` and `inlineStyles` plugins to pass the element's attribute value for smarter matching. Closes svg#2145 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #2145.
includesAttrSelectorpreviously only checked whether an attribute name was referenced in a CSS selector, ignoring the selector's operator and value. This caused SVGO to conservatively keep attributes even when the CSS selector would not actually match the element's attribute value.Changes
matchesAttrAction()helper that evaluates all CSS attribute selector operators (=,^=,$=,*=,~=,|=,exists) against an element's actual attribute valueattrValueparameter toincludesAttrSelector()— when provided, the selector's operator is evaluated against the element's real value instead of assuming a matchremoveUnknownsAndDefaultsandinlineStylesplugins to pass the element's attribute valueattrValueis not provided, the function retains its existing conservative behaviorExample (from the issue)
Test Coverage
includesAttrSelectorcovering all 7 operator types, edge cases (empty values, comma-separated selectors), backward compatibility, and the exact issue exampleremoveUnknownsAndDefaults(operator non-match allows removal; operator match keeps attribute)