fix(removeAttributesBySelector): update for v2 API#1978
Open
soren121 wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
@KTibow Are you interested in merging this? Respectfully, this PR is two years old, I'm not going to put in effort keeping it up-to-date if it's not going anywhere. |
Collaborator
|
Just let me know when you update it and I'll run CI and review it. |
soren121
force-pushed
the
remove-attributes-by-selector
branch
from
9aaf1a4 to
6deb8db
Compare
soren121
force-pushed
the
remove-attributes-by-selector
branch
from
6deb8db to
6864872
Compare
Contributor
Author
|
@KTibow Thanks! Conflicts fixed & ready for review again. |
KTibow
added a commit
that referenced
this pull request
Apr 9, 2026
…2215) I'm uncertain if the switch to `matches` in #1978 is a good idea perfwise. But it has a subset which are clearly good ideas, so this PR is just those. - better documentation - better types - warning on incorrect configuration - more tests --------- Co-authored-by: soren121 <soren121@users.noreply.github.com>
soren121
changed the title
soren121
force-pushed
the
remove-attributes-by-selector
branch
from
7aa82e1 to
f6153d7
Compare
soren121
force-pushed
the
remove-attributes-by-selector
branch
from
f6153d7 to
fd06994
Compare
Contributor
Author
|
I don't have much of an opinion on whether Feel free to close this if you're not interested in the remaining changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a general cleanup PR for the
removeAttributesBySelectorplugin. It was never updated for the v2 API, and its doc page was not very clear on how to use it; this PR addresses both.Changes
Added a check to avoid runtime errors when plugin is not configured, or misconfiguredAdded a test to ensure plugin is a no-op when not configuredExpanded and clarified the plugin's doc pageAdded TypeScript parameter typesedit: other changes merged as #2215