Add failed tests#21
Open
sushantmane wants to merge 11 commits into
Open
Conversation
|
||||||||||||||
sushantmane
force-pushed
the
tmp-test
branch
from
2007f82 to
1857eb7
Compare
This reverts commit b0f9942.
sushantmane
force-pushed
the
tmp-test
branch
from
1857eb7 to
bb25365
Compare
sushantmane
force-pushed
the
tmp-test
branch
from
bb25365 to
a964f9f
Compare
sushantmane
force-pushed
the
tmp-test
branch
from
a964f9f to
e366e08
Compare
This reverts commit f4f76c5.
- Add controller handler service and gRPC server with secure mode - Implement create store, get store, getAllStores, list stores APIs - Add proto definitions for Stores and empty push - Enable configuration to toggle gRPC server on/off - Fix error handling and transport in ControllerClient for test compatibility - Add additional routes: AdminCommandExecution, AdminTopicMetadata, Cluster, Version - Update Docker setup for gRPC compatibility Add experimental changes Add integration test
sushantmane
force-pushed
the
tmp-test
branch
from
e366e08 to
496579d
Compare
sushantmane
added a commit
that referenced
this pull request
May 11, 2026
…nce 1 -> 3 Token-bucket throttler in ReadRequestThrottler refills partially between requests on the per-second window. The test sends 21 requests expecting #21 to trip throttling, with a tolerance of 1 extra request. On a loaded CI (maxParallelForks=4) the first 21 requests can take ~120ms wall-clock — enough for the bucket to refill a partial token, requiring 2 extra requests to drain. Raise tolerance to 3. Preserves the regression-catching property — any leak that needs more than 3 extra requests is still a real bug — while absorbing CI scheduling jitter.
sushantmane
added a commit
that referenced
this pull request
May 14, 2026
…nce 1 -> 3 Token-bucket throttler in ReadRequestThrottler refills partially between requests on the per-second window. The test sends 21 requests expecting #21 to trip throttling, with a tolerance of 1 extra request. On a loaded CI (maxParallelForks=4) the first 21 requests can take ~120ms wall-clock — enough for the bucket to refill a partial token, requiring 2 extra requests to drain. Raise tolerance to 3. Preserves the regression-catching property — any leak that needs more than 3 extra requests is still a real bug — while absorbing CI scheduling jitter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary, imperative, start upper case, don't end with a period
Add failed tests
Resolves #XXX
How was this PR tested?
Does this PR introduce any user-facing changes?