character limit for local username#5594
Open
Khooaaa wants to merge 2 commits into
Open
Conversation
Contributor
|
The value 50 should be in a configuration value |
Alayan-stk-2
requested changes
Dec 24, 2025
Alayan-stk-2
left a comment
Alayan-stk-2
left a comment
Member
There was a problem hiding this comment.
Thank you for your Pull Requests!
The extra + symbols need to be removed. It seems like you copied from a patch file and forgot to check if the code actually compiles.
Wil's suggestion of making the limit configurable in something like stk config also makes some sense, although it's more of a nice to have.
| { | ||
| if (local_name.size() == 0) | ||
| return; | ||
| if (local_name.empty()) |
Member
There was a problem hiding this comment.
You've put actual + symbols in your code, this won't even compile properly.
GustaLOLE
added a commit
to GustaLOLE/stk-code
that referenced
this pull request
Feb 4, 2026
- I used the Khooaaa's pull request to start;
- I reduced the limit from 50 to 30 characters (to stay like creating online accounts);
- I changed the line (and function) when Khooaaa puts the if-case:
Before: Was in RegisterScreen::handleLocalName, not working properly;
After: Are now in RegisterScreen::doRegister(), and it's not working.
GustaLOLE
added a commit
to GustaLOLE/stk-code
that referenced
this pull request
Jun 27, 2026
- I started my work basing in the PR supertuxkart#5594, made by Khoaaa (thx for the initial work btw) - The local username length now is limited to 30 characters, but can be changed in user_config.xml (with UI overflows risk).
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit local username to 50 characters
issue #5555
Agreement