rewrite magisk module: bl_flasher in Rust, webui in React + TypeScript#62
Open
Dere3046 wants to merge 21 commits into
Open
rewrite magisk module: bl_flasher in Rust, webui in React + TypeScript#62Dere3046 wants to merge 21 commits into
Dere3046 wants to merge 21 commits into
Conversation
Author
|
This is meaningless. rather remove it. |
Dere3046
changed the title
Author
|
Yes, I wrote this load of shit. |
Author
|
The logging system is quite chaotic. How should I refactor it? |
Signed-off-by: Littlenine <LittlenineEnnea@gmail.com>
Collaborator
ill give a separate for the logging system |
Author
|
Should we consider adding anti-rollback version detection here? |
Author
|
CI failed on downloading; network flake, unrelated to this PR. |
Collaborator
i think this merge is ok, but i need to ask the main maintainer's advice @superturtlee |
Author
It looks as though they’re doing something else |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI: https://github.com/TheGeniusClub/gbl_root_canoe/actions/runs/27147051434