ci: Replace ci.yml with better git-hooks check - #2482
Merged
Merged
Conversation
Contrary to what file name (ci.yml) and workflow name (Check merge requirements) lead you to believe, this workflow is only checking the postgres version values in ansible/vars.yml file. We already had a git-hooks based hook checking the version, albiet just for cli, that could be extended to this use. Moving to git-hooks means its also available as a pre-commit/pre-push hook!
mmlb
changed the title
mmlb
enabled auto-merge
September 22, 2026 18:46
PostgreSQL Extension Dependency Analysis: PR #2482
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2482
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
Collaborator
|
Looks good! Iirc hooks run as checks too, if not plz add them to checks as well. |
brainrake
approved these changes
Sep 23, 2026
Collaborator
Author
|
Yep hooks always run on every nix-build run (I would guess there's a |
Collaborator
Author
|
Dropping the no-longer-existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Maintenance
What is the current behavior?
We check the supabase pg versions defined in ansible/vars.yml for matching our versioning scheme in 2 places and thus 2 different ci workflows. Its also not very complete.
What is the new behavior?
Moved checks from the not very well named ci.yml file into hooks.nix which already runs via nix-build.yml and can be used by pre-commit so bad values are never pushed.