Repository navigation
fix(framework): keep Codex LLM spans non-empty during backgrounded commands - #382
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the empty/0s LLM spans Matt reported in Braintrust traces (Slack thread). Since #356, Codex tool spans end at
item_completed, so a backgrounded command (supabase stack start … &) can end after later model requests.logTranscriptstarted each LLM span atmin(latestTime, at), which collapsed tostart == endwhenever an earlier tool outlived the request.An LLM span now starts at the latest span edge at or before its own timestamp. Start times are unchanged when nothing overruns.
Verification
upload-braintrust.test.ts. It fails onmainand passes with the fix.logTranscript: zero-length LLM spans went from 31 to 0, and no durations are negative.