Repository navigation
ci: skip CI on the generated eval results commit - #332
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
The eval-refresh workflow pushes "chore: refresh eval results" back onto the PR head branch with GITHUB_TOKEN. That push does not fire `push` workflows, but it does fire `pull_request: synchronize`, so Refresh eval results and Code Quality re-run as github-actions[bot] and sit in "approval required" for a maintainer (see #281). Because the refresh is label-gated, the re-run would also refresh again. Append the skip-ci marker to the direct-push results commit so GitHub creates no runs for it. The scheduled/dispatch path that opens a fresh results PR through create-pull-request is unchanged and still gets normal CI. main has no required status checks, so a skipped head commit does not block merging. Refs: AI-1254 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ECba2eYo5iJPLnVPT8JvkV
claude
Bot
force-pushed
the
claude/skip-ci-on-refresh-commit
branch
from
September 24, 2026 13:34
02877ea to
2525034
Compare
…ecovery to exercise the refresh commit in CI Adds a behaviour-neutral comment to the eval's scorer so the run-evals-changed path resolves to a non-empty pairs list and the workflow's direct-push results commit executes. This commit will be reverted before merge. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ECba2eYo5iJPLnVPT8JvkV
Reverts 48b346e, the results commit the workflow pushed while exercising the run-evals-changed path on this PR. The results were only generated to prove the skip-ci behaviour; they are not part of this change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ECba2eYo5iJPLnVPT8JvkV
…roject-recovery Reverts f5f68c4 now that the refresh commit has been exercised in CI. The PR's diff is back to the workflow and CONTRIBUTING changes only. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ECba2eYo5iJPLnVPT8JvkV
Contributor
Author
|
Proof the
Generated by Claude Code |
mattrossman
reviewed
Sep 24, 2026
Replace the six-line comment above the results commit with a one-line explainer plus the GitHub docs link, and restore CONTRIBUTING.md to main's version, per review feedback on #332. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ECba2eYo5iJPLnVPT8JvkV
mattrossman
approved these changes
Sep 24, 2026
mattrossman
marked this pull request as ready for review
September 24, 2026 14:14
Rodriguespn
approved these changes
Sep 24, 2026
mattrossman
added a commit
that referenced
this pull request
Oct 8, 2026
## Motivation We have unit / e2e tests across `apps/*` and `packages/*` but don't run them or type checks in CI, so they quietly regress (e.g. #351 broke a Codex parser test that #366 added the same day). ## Changes - Code Quality gets a `typecheck` job next to `format` - A new Tests workflow runs `test`, `test-platform-lite` (which is slow enough for its own parallel job), and `test-docker`. The Docker tests take ~2.5 min, so they only run when a PR touches relevant files ([skipped example](https://github.com/supabase/evals/actions/runs/37680288402/job/112994246780)). - Refresh results commits drop `[skip ci]` (added in #332) and push with our GH App token instead, so required checks run on them without approval. A `run-evals-changed` refresh's [results commit](b57f997) ran CI as the app with no approval prompt and didn't start another refresh. - Upgraded to Vitest v5 so we get per-package labels on the job summary (compare [before](https://github.com/supabase/evals/actions/runs/37533147821) and [after](https://github.com/supabase/evals/actions/runs/37630783292)). | [Tests](https://github.com/supabase/evals/actions/runs/37679563185) | [Code Quality](https://github.com/supabase/evals/actions/runs/37679562944) | | --- | --- | | <img alt="CleanShot 2026-10-07 at 4 16 00 PM@2x" src="https://github.com/user-attachments/assets/8593f06b-d45a-4576-b346-163caec4689f" /> | <img alt="CleanShot 2026-10-07 at 3 37 37 PM@2x" src="https://github.com/user-attachments/assets/5600cda5-208d-432c-8b18-534c6f06f7f5" /> | Example with tests failing ([run](https://github.com/supabase/evals/actions/runs/37666155427)): <img alt="CleanShot 2026-10-07 at 2 24 36 PM@2x" src="https://github.com/user-attachments/assets/47b7d635-616c-47bc-806a-428fe851c78d" /> I added `OPENAI_API_KEY` to [Dependabot secrets](https://github.com/supabase/evals/settings/secrets/dependabot) so Tests runs on Dependabot PRs. Fork PRs don't get secrets as is the case on [supabase/mcp](https://github.com/supabase/mcp). ## Follow-ups - After merge, require `format`, `typecheck`, `test`, `test-platform-lite`, and `test-docker` on the [`main: review required`](https://github.com/supabase/evals/settings/rules/18775100) ruleset. - AI-934: replace the framework [smoke tests](https://github.com/supabase/evals/blob/5f8de50a5e8c8ef40d983d9aff9030dd25080a89/apps/framework/scripts/smoke-framework.ts) with per-scorer Vitest files. - AI-1295: cut platform-lite setup time with PGlite snapshots. Closes AI-1121 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matt Rossman · Slack thread
The eval-refresh workflow's
GITHUB_TOKENpush ofchore: refresh eval resultsonto a PR branch still firespull_request: synchronize, so Refresh eval results and Code Quality re-run asgithub-actions[bot]and sit in "approval required" (seen on #281). This appends[skip ci]to that direct-push commit so GitHub creates no runs for it, leaving the create-pull-request path and its CI untouched (AI-1254).🤖 Generated with Claude Code
https://claude.ai/code/session_01ECba2eYo5iJPLnVPT8JvkV
Closes AI-1254
Generated by Claude Code