Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Rodriguespn
force-pushed
the
Rodriguespn/pr308-nested-experiments-proposal
branch
from
September 22, 2026 11:51
a2edffd to
1e930b2
Compare
Splits the final chunk out of the closed #308: the cli suite/experiment enums, CODEOWNERS scoping, the four forced-environment CLI experiment columns plus their skip predicates, and CI wiring so the eval-refresh and gh-pages-history workflows know about the new suite.
presets.ts landed without the baselineExperiment alias these spread, and typechecking experiments/ now needs the test files excluded.
Coly010
force-pushed
the
columferry/cli-eval-suite
branch
from
September 22, 2026 18:57
bdbaafe to
9cba14a
Compare
Coly010
changed the base branch from
Rodriguespn/pr308-nested-experiments-proposal
to
columferry/sandbox-docker-availability
September 22, 2026 18:57
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final chunk of the closed #308. This is the piece @mattrossman asked for — the minimal CLI suite plumbing and CODEOWNERS, standalone, with no CLI experiment internals to review. My own commit is 258 lines across 14 files, and five of those files are 11–13 lines each.
What it adds
clias an eval suite and an experiment suite,@supabase/cliownership over/evals/cli/,/experiments/cli/andcli-eval-results.json, and the workflow wiring soeval-refreshandappend-gh-pages-historyknow the suite exists.The substance is five environment columns: one scenario run unchanged across forced CLI environments, so a failure isolates to which environment broke. They're thin now that
experiments/presets.tsexists — the whole of the Docker-less column is:codex-gpt-5.6-lunainterface: clieval…-cli-stablelatestinterface: clieval…-cli-betabetainterface: clieval…-cli-nodaemonneedsDocker: false+projectRunning: false…-cli-absentdockerbinaryneedsDocker: false+projectRunning: falseThe pinned column is the existing baseline with
'cli'added to itssuitearray, not a new file — same as how the docs suite works today (codex-gpt-5.6-luna-no-skillscarries'docs'; the docs team never got a duplicate column). A dedicated file would be a byte-identical copy ofbaselineExperimentunder a second name. That's the one line here outside CLI-owned paths, hence @supabase/ai on the review.skipUnlessCli/skipUnlessDockerlessare the only things left over from the oldexperiments/_lib/; they live inexperiments/cli/lib/, which discovery ignores for free since it only matches*.experiment.tsdirectly under an owner directory.Verified, including the parts tests can't reach
format:check,typecheck, and the sandbox (89), core (162), framework (8),test:cli-lib(11), vercel-runner (29) and web (83) suites all pass.Two things unit tests can't cover, checked directly instead:
experiments/cli/lib/is correctly not treated as an experiment, and the five columns resolve to the intended runtimes (local-stack,local-stack-stable,local-stack-beta,local-stack-beta-no-daemon,local-stack-beta-absent).node --import tsx/esmbody against live npm:stable: 2.117.0,beta: 2.118.0-beta.60, with the release-asset existence check passing on beta.60.test:cli-libcarries--passWithNoTestsdeliberately:evals/cli/has no scorer tests until #281/#314/#316 land, and without the flag the script's exit code depends on which of its two paths happens to be populated.Next
#281, #314, #316 and #307 get re-parented onto this branch in one pass once the dependency chain above clears — they currently point at the closed #308's retained branch. /cc @Rodriguespn @kanadgupta