Repository navigation
feat: add typed Problem details and consistent API errors - #510
Merged
Merged
Conversation
Expose typed Problem details and preserve error response context. Add focused regression coverage and concise integration examples.
Run lint with the same project formatter used by the build so dependency and CI formatting rules stay aligned.
Keep the HTTP status and response when reading an error body fails, and retain the reading error as the cause. Preserve explicit caller cancellation.
Keep the basic error example with the usage guide so integrators can find it before the events and example sections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed requests now expose typed Problem details through
error.problem. HTTP errors use consistent status-based exceptions, and connection failures and timeouts retain their original cause. Caller cancellation keeps its existing behavior.Malformed error JSON remains an API error with its HTTP status and text. Reading error details also leaves
error.responseavailable for inspection. If reading the body fails, the HTTP status and response headers remain available, with the reading failure incause.Existing
APIErrorcatches anderror.erroraccess continue to work. Connection failures now raiseAPIConnectionError, with the original failure incause.CI lint uses the same locked formatter as the package build, avoiding conflicting formatting rules.
The README shows the common error handling path beside SDK usage, with access to the original response for other error details.
Related to sumup/sumup-py#434 and the Python SDK changes in sumup/sumup-py#436.