Repository navigation
refactor(events): reuse generated event schemas and types - #459
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Event handling defined its own envelope and resource-reference fields even though the generated SDK already provides these schemas. Extend
WebhooksEvent, reuseEventObjectdirectly, and useEventTypeandEventObjectTypein dispatch and generated event classes.Use the generated models' string validation instead of separate nonempty-string validators. Keep signature verification, read-only event discriminators, timezone-aware timestamps, object-type matching, unknown-event fallback, and typed resource fetching. Per-event literals remain to validate each callback's event type. Update the generator template and regenerate the SDK.
Validation: all 190 Python tests pass, along with Ruff lint/format checks and ty type checking. Generator tests passed for the template change. Coverage verifies generated-schema compatibility and future object types.