Repository navigation
feat!: preserve HTTP context alongside typed API errors - #352
Merged
Merged
Conversation
Expose typed Problem details and preserve error response context. Add focused regression coverage and concise integration examples. BREAKING CHANGE: API errors now wrap documented bodies. Use errors.As to inspect typed errors instead of direct assertions.
Place error handling beside the usage guide and show the API request that produces the inspected error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed API calls now retain their HTTP status, headers, and original response bytes in
APIError. Documented bodies remain accessible througherrors.As, including Problem responses.Malformed and unexpected error bodies retain their response context. Transport errors keep their existing wrapping and cancellation behavior.
Compatibility: documented errors are now wrapped in
*APIError. Useerrors.Asinstead of a direct type assertion to inspect a typed body.The README shows the common error handling path beside SDK usage, with access to the original response for other error details.
Related to sumup/sumup-py#434 and the Python SDK changes in sumup/sumup-py#436.