docs: correct stale comments left over from prior refactors - #227
Merged
Merged
Conversation
- build-changelog.py: the module-level DESIGN comment still described the old positional-insertion strategy (insert BETWEEN [Unreleased] and the first ### heading). The compiler has used boundary-marker replacement (FRAGMENT_BLOCK_START/END) for a while now, and the function's own docstring already documents that correctly - only the top-of-file comment was stale. - build_skills.py: PACKAGES_FIELD_RE only matches the inline bracket form (`packages: [a, b]`); the comment claiming block-list support was never accurate for this regex. Also drop --package's help text reference to an "_active filter" that resolve_packages() no longer has (there is now exactly one supported package). - 2026-07-12 license plan doc: fix a script-name typo (build_changelog.py -> build-changelog.py) in a verification command block. No behavior change: build_skills.py --check and the build-changelog unit tests (24 tests) pass identically before and after.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reapplies 3 of 11 uncommitted local edits that were stashed before pulling 123 commits from
origin/main. The other 8 were checked against the new upstream content and dropped: 3 were superseded by upstream changes (schema version bump, a deleted/consolidated skill file, a rewritten migration doc), 4 were based on a misunderstanding ({{ mcp_tool_ask }}is a live build-time template variable resolved byscripts/skill-build-config.json, not stale text — hardcoding it would have broken per-package templating), and 1 (check-public-export-safety.py's AST-based literal-masking behavior) needs deeper review than a comment-fix PR should carry, so it's being left out rather than guessed at.scripts/build-changelog.py: the module-level DESIGN comment still described the old positional-insertion strategy (insert BETWEEN[Unreleased]and the first###heading). The compiler has used boundary-marker replacement (FRAGMENT_BLOCK_START/END) for a while now, andcompile_changelog()'s own docstring already documents that correctly — only the top-of-file comment was stale.scripts/build_skills.py:PACKAGES_FIELD_REonly matches the inline bracket form (packages: [a, b]); the comment claiming YAML block-list support was never accurate for this regex. Also drops--package's help text reference to an_activefilter thatresolve_packages()no longer has (there's now exactly one supported package, enforced bySystemExit).docs/superpowers/plans/2026-07-12-agent-collab-v3.1.0-license.md: fixes a script-name typo (build_changelog.py→build-changelog.py) in a verification command block.No behavior change — see Verification.
Boundary declaration
Generated and release surfaces
SKILL.mdfiles are in parity. (build_skills.py --checkpasses identically before/after.)changelog.d/fragment — not added; this is a comment/typo-only fix with no user-visible behavior change.Verification
python3 scripts/build_skills.py --check→OK: all generated SKILL.md files match source specs.python3 -m unittest scripts.test_build_changelog tests.test_build_skills_description_limit -v→ 24 tests, all pass.git diff --check→ clean.python3 scripts/check_release_consistency.py(ran via pre-commit hook) →RESULT: OK.python3 scripts/build-changelog.py --check— pre-existing, unrelated failure (uncompiled fragment drift onmain, not caused by this change).python3 -m unittest discover/secret_scan.py/check-public-export-safety.py --active-tree --history— blocked in this local checkout by pre-existing untracked debris unrelated to this diff: stray retired package directories underplugins/(antigravity-collab,claude-collab,codex-collab— confirmed untracked viagit ls-files, not nested repos, left over from before the provider-package retirement) and an unreadable.claude-worktrees/directory. Scoped the two dedicated unit-test modules above instead, which cover the exact functions touched.Review and post-condition
Tier: 1 (pure comment/typo correction; zero logic change — confirmed by
build_skills.py --checkpassing identically and by readingcompile_changelog()'s own docstring, which already matches current behavior). No cross-check round required per Tier 1 process.Post-condition: none — no runtime, schema, or generated-artifact change to verify post-merge.
Compliance trace
author: claude
standing_directives: agent-collab-workspace directive #6 (Tier 1 fast-path); Session calibration (verify by positive observation)
tier: 1
cross_check: N/A — Tier 1 pure comment/typo fix, no cross-check round required
post_condition: none — no runtime/schema/generated-artifact change
mcp_coverage_gap: NONE
contributor_rights: OPERATOR-CONFIRMED
operator_reserved: no