Apply codex suggestions for pre release#93
Merged
alexander-schranz merged 3 commits intoMay 20, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR applies pre-release review suggestions by updating upgrade/documentation notes and removing deprecated/backward-compatibility code paths in the test bootstrap and task repository API.
Changes:
- Updated 3.0 upgrade notes around Task entity/task repository changes and removed references to deprecated APIs.
- Simplified
Tests/bootstrap.phpby dropping legacy compatibility fallbacks and usingDotenv::loadEnv(). - Removed deprecated
countFutureTasks()fromTaskRepositoryInterfaceand the Doctrine implementation.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| UPGRADE-3.0.md | Adjusts upgrade guidance for Task relation/repository changes (but contains an inaccurate snippet that needs correction). |
| Tests/bootstrap.php | Removes legacy compatibility layers and uses loadEnv() for env loading. |
| Tasks/Model/TaskRepositoryInterface.php | Drops deprecated countFutureTasks() from the public interface. |
| Entity/DoctrineTaskRepository.php | Removes the countFutureTasks() implementation. |
| Resources/doc/README.md | Updates local documentation intro text (contains a typo). |
| Resources/doc/installation.md | Adds a requirements section and improves wording in installation steps. |
| README.md | Updates badges and requirements to reflect the 3.0 branch/support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexander-schranz
force-pushed
the
codex/suggestions-pre-3.0-release
branch
from
9d1e2a6 to
6073747
Compare
Prokyonn
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Apply codex suggestions for pre release.
Why?
Review of the RC by codex.