✨(filters) add subContent in options#261
Open
NathanVss wants to merge 3 commits into
Open
Conversation
NathanVss
force-pushed
the
feat/menu-custom-elements
branch
2 times, most recently
from
7da70c2 to
853e530
Compare
An option can now declare a `subContent` panel: the row renders a chevron and opens (on hover or keyboard) a sub-panel hosting any component, e.g. a date range picker, with `select` / `close` helpers to drive the parent selection. Selection is read from the ListBoxItem `isSelected` render prop (the collection pass has no SelectStateContext), and the component uses the value-based Select API (value / onChange / setValue) since selectedKey / selectedItem are now deprecated by react-aria.
Showcase the `subContent` API with an "Updated" filter whose Custom option opens a CalendarRange, plus a Reset button. Document the option and prop API and switch the examples to the non-deprecated value / defaultValue / onChange selection props.
Playwright component tests (with a browser-side mount helper, since CT can't pass render props from the spec) covering selection, the selected-option checkmark, the chevron affordance, hover- and keyboard-opening of the sub-panel, the click-is-ignored behaviour, range confirm / cancel, and reset.
NathanVss
force-pushed
the
feat/menu-custom-elements
branch
from
853e530 to
d20cbd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A
Filteroption can now declaresubContent— it renders with a chevron and opens ahover sub-panel hosting any component. Showcase: an "Updated" filter whose Custom
option opens a cunningham
CalendarRange.Notes
ListBoxItemisSelectedrender prop (the collection passdoesn't have resolved Select state, so reading context was unreliable).
selectedKey/defaultSelectedKey/onSelectionChange→value/defaultValue/onChange(old props still pass through).