🐛(frontend) stop overwriting saved language on page load#1414
Open
rezk2ll wants to merge 1 commit into
Open
Conversation
Adopt the server language as the source of truth on load and push only on a user-driven change. Timezone keeps following the browser.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every page load pushes the browser's detected language back to the user endpoint, overwriting whatever the server had. A language saved in settings gets reverted whenever it disagrees with the browser locale, so signing in from a different browser locale silently changes the saved preference.
#1363
Solution
Treat the saved language as the source of truth: adopt it into the UI on load, and PUT only when the user picks a language in the settings panel. Timezone keeps following the browser as before.