Skip to content

♿️(frontend) remove redundant aria-label on table of contents links#2459

Open
Ovgodd wants to merge 1 commit into
mainfrom
fix/a11y-anchor-link-redundant-label
Open

♿️(frontend) remove redundant aria-label on table of contents links#2459
Ovgodd wants to merge 1 commit into
mainfrom
fix/a11y-anchor-link-redundant-label

Conversation

@Ovgodd

@Ovgodd Ovgodd commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Purpose

Remove redundant aria-label on TOC links (2390 follow-up). Visible link text is already an explicit accessible name.

Proposal

  • Remove aria-label from TOC Heading anchors

@Ovgodd Ovgodd force-pushed the fix/a11y-anchor-link-redundant-label branch from 083af38 to 01e340b Compare June 24, 2026 09:29
@Ovgodd Ovgodd requested a review from AntoLC June 24, 2026 09:29
@Ovgodd Ovgodd self-assigned this Jun 24, 2026
@Ovgodd Ovgodd moved this from Backlog to In progress in LaSuite Docs A11y Jun 24, 2026
@Ovgodd Ovgodd marked this pull request as ready for review June 24, 2026 09:31
Removed redundant aria-label to fix double SR announce.
@Ovgodd Ovgodd force-pushed the fix/a11y-anchor-link-redundant-label branch from 01e340b to 607a1ce Compare June 24, 2026 09:31
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 13842af4-f38c-474d-a15e-996569a31dfe

📥 Commits

Reviewing files that changed from the base of the PR and between c8e44dd and 607a1ce.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • src/frontend/apps/impress/src/features/docs/doc-table-content/components/Heading.tsx
💤 Files with no reviewable changes (1)
  • src/frontend/apps/impress/src/features/docs/doc-table-content/components/Heading.tsx

Walkthrough

The aria-label={text} attribute is removed from the anchor element (Box as="a") inside the Heading component in the table of contents feature. The remaining accessibility attribute on the element is the conditional aria-current. A corresponding changelog entry is added under the [Unreleased] → Changed section.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • AntoLC
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: removing redundant aria-labels from frontend TOC links.
Description check ✅ Passed The description directly states the accessibility change and matches the code updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/a11y-anchor-link-redundant-label

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Size Change: +1 B (0%)

Total Size: 4.34 MB

📦 View Changed
Filename Size Change
apps/impress/out/_next/static/806b9ca1/_buildManifest.js 0 B -674 B (removed) 🏆
apps/impress/out/_next/static/978a019d/_buildManifest.js 675 B +675 B (new file) 🆕

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

1 participant