Skip to content

fix: make address be optional in signing payload schema (0.4.3)#14

Merged
rafa-stacks merged 5 commits into
masterfrom
fix/optional-address
Mar 25, 2026
Merged

fix: make address be optional in signing payload schema (0.4.3)#14
rafa-stacks merged 5 commits into
masterfrom
fix/optional-address

Conversation

@rafa-stacks

@rafa-stacks rafa-stacks commented Mar 24, 2026

Copy link
Copy Markdown
Collaborator

Per Rosetta spec, it's deprecated and already included in the account_identifier right next to it.
Also tag v0.4.3 for release.

@rafa-stacks rafa-stacks changed the title fix: make address be optional in signing payload schema fix: make address be optional in signing payload schema (0.4.3) Mar 25, 2026
heidar-stacks
heidar-stacks previously approved these changes Mar 25, 2026

@heidar-stacks heidar-stacks left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small nonblocking nits

Comment thread packages/schemas/src/schemas/entities/construction.ts Outdated
Comment thread packages/schemas/src/schemas/entities/construction.ts Outdated
Comment thread packages/schemas/src/schemas/entities/construction.ts
@rafa-stacks rafa-stacks merged commit 4bf1371 into master Mar 25, 2026
14 checks passed
@rafa-stacks rafa-stacks deleted the fix/optional-address branch March 25, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants