fix(catalog): separate live and legacy issue records (#111) - #149
Merged
Merged
Conversation
The preflight overlay's github_issues records were numbered against the retired repository, whose numbers overlap this repository's sequence, so every record and most backlog rows resolved to an unrelated issue. - github_issues entries carry `repository`. Live records are `#<n>` in studio-berry/loop; frozen legacy snapshots are `legacy#<n>`. - The generator refuses an open legacy record as a row's `closed_by`, and a bare `#<n>` in gap text no longer satisfies a `legacy#<n>` record. - `--verify-github` reads live records back with gh and rejects a missing issue, a pull request, or a changed title, state, or milestone. - Sixteen open backlog rows re-point to the reset issues filed for them. - The 28 legacy issue and PR URLs under docs/ become `legacy #<n>` text; docs/LEGACY_ISSUE_PROVENANCE.md records the convention and re-pointing. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… proof lanes Rewriting one link in docs/GOVERNED_EXECUTION.md makes governed-execution a touched subsystem, which requires build and packaging proof lanes that a documentation change cannot carry. Restore the file and record the exception. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
docs/adr/adr-011-architecture-contracts-d1-d5.md is owned by the governed-execution subsystem, like docs/GOVERNED_EXECUTION.md. Restore it and correct the counts in the fragment and provenance doc. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #111. Repo-side half of G00-01; the issue-body and roadmap-page halves are under "Outside the repo".
Problem
The preflight overlay's
github_issuesrecords were numbered against the retired repository. Its numbers overlap this repository's sequence, so every record and most open backlog rows resolved to an unrelated issue (legacy #47 and #49 opened L06-01 and L06-03; legacy #12 opened L11). The generator checked record shape only, so nothing could catch it.Changes
github_issuesentries carryrepository. Live records are#<n>instudio-berry/loop; frozen legacy snapshots arelegacy#<n>with repositorylegacy.closed_by, and a bare#<n>ingaptext no longer satisfies alegacy#<n>record.--verify-github(opt-in, needsgh, not run in CI) reads live records back and rejects a missing issue, a pull request, or a changed title, state, or milestone. Issue and PR numbers share one sequence, so a PR collision is reported as such.legacy#<n>snapshots. Provenance table indocs/LEGACY_ISSUE_PROVENANCE.md.docs/becamelegacy #<n>text.docs/PREFLIGHT_COVERAGE_MATRIX.mddocuments the two record kinds and the flag.Outside the repo
legacy #<n>text. Links from the parent issues to the new sub-issues were left alone.Not in this PR
Three legacy links stay:
docs/GOVERNED_EXECUTION.md(1) anddocs/adr/adr-011-architecture-contracts-d1-d5.md(2). Both belong to the governed-execution subsystem, whose binding proof lanes (UnitTestsGovernedExecution, packaging builds) a documentation change cannot carry, and building needs approval.check-architecture.pyfailed on them, so I restored both files rather than claim evidence I don't have.The retired repository is not reachable from
studio-berryormberrys, so links cannot be re-homed to an archive. Content is recoverable from the Notion Loop Issues and Sessions ledgers.Verification
python scripts/generate-architecture-catalogs.py --checkpasses;--check --verify-githubpasses against live GitHub.scripts/ci/test_preflight_check_catalog.py,test_preflight_corpus_coverage.py,test_correction_operation_catalog.py: 62 tests pass (10 new, 1 updated).python scripts/agent/check-change.py --base origin/dev: pass (modules: documentation).🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.