Skip to content

termios: fix normal cursor shape set by ESC[v #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stsp merged 1 commit into from
Oct 3, 2026
Merged

termios: fix normal cursor shape set by ESC[v #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/libc/posix/termios/tmwrite.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,6 +737,10 @@ set_cursor_shape(int shape)
{
new_cursor = 0x2000;
}
else if (shape == NORMAL_CURSOR)
{
new_cursor = __tty_screen.init_cursor_shape;
}
else
{
max_line = _farpeekw(_dos_ds, 0x0485) - 1;
Expand All @@ -757,7 +761,7 @@ set_cursor_shape(int shape)
if (shape == ENHANCED_CURSOR)
top_line = 0;
else
top_line = bot_line + 1;
top_line = bot_line - 1;

@stsp stsp Oct 3, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets CC @jwt27 as this looks like
a genuine djgpp bug.
But given that we ended up needing
also the change above, this point is moot.


new_cursor = ((top_line & 0x1f) << 8) | (bot_line & 0x1f);
}
Expand Down
Loading