Skip to content

fix: resolve d3-raw cumulative x-axis misalignment by snapshotting cycling data source #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
streamcode9 merged 1 commit into from
Feb 27, 2026
Merged

fix: resolve d3-raw cumulative x-axis misalignment by snapshotting cycling data source #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions samples/competitors/d3-raw/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,15 +126,18 @@ async function initChart(): Promise<void> {
clearInterval(intervalId);
}
let j = 0;
const originalData = { series, dates };
// Snapshot the original values so the cycling source is immune to addDataPoint mutations
const originalNyValues = [...series[0]!.values];
const originalSfValues = [...series[1]!.values];
const originalLength = dates.length;
intervalId = setInterval(function () {
const dataIndex = j % originalData.dates.length;
const dataIndex = j % originalLength;
const newDate = new Date(
dates[dates.length - 1]!.getTime() +
(dates[1]!.getTime() - dates[0]!.getTime()),
);
const newNyValue = originalData.series[0]!.values[dataIndex]!;
const newSfValue = originalData.series[1]!.values[dataIndex]!;
const newNyValue = originalNyValues[dataIndex]!;
const newSfValue = originalSfValues[dataIndex]!;

// Add new data point to each series
chartControls.addDataPoint(newDate, [newNyValue, newSfValue]);
Expand Down