fix: resolve zoom desynchronization during rapid scrolling#274
Merged
Conversation
- Fire user-initiated afterZoom callbacks synchronously so follower charts schedule RAF in the same event-handler turn, preventing them from lagging one frame behind the leader during rapid mouse wheel scrolling - Accept newer programmatic transforms instead of reverting to previous ones when conflict occurs, ensuring follower charts stay up-to-date during rapid zoom/pan events at axis boundary transitions (month/date labels) - Update tests to reflect new callback behavior (user events now fire callbacks eagerly instead of deferred in RAF) Fixes desynchronization lag when zooming across month/date boundaries in multi-chart layouts
✅ Deploy Preview for endearing-pothos-ca88dc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Owner
Author
|
Closes #264 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fire user-initiated afterZoom callbacks synchronously so follower charts schedule RAF in the same event-handler turn, preventing them from lagging one frame behind the leader during rapid mouse wheel scrolling
Accept newer programmatic transforms instead of reverting to previous ones when conflict occurs, ensuring follower charts stay up-to-date during rapid zoom/pan events at axis boundary transitions (month/date labels)
Update tests to reflect new callback behavior (user events now fire callbacks eagerly instead of deferred in RAF)
Fixes desynchronization lag when zooming across month/date boundaries in multi-chart layouts