refactor: use D3 .raise() for element reordering#263
Merged
streamcode9 merged 1 commit intoFeb 10, 2026
Merged
Conversation
Replace vanilla appendChild() calls with idiomatic D3 .raise() method when reordering zoom overlay and brush layer elements after resetData(). This change: - Uses D3's declarative API instead of mixing D3 selections with DOM APIs - Better expresses intent (bring to front vs append) - Maintains same performance and behavior - Continues refactoring toward more idiomatic D3 patterns Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
✅ Deploy Preview for endearing-pothos-ca88dc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appendChild()calls with idiomatic D3.raise()methodChanges
Updated
svg-time-series/src/draw.tsin theresetData()method:svgNode.appendChild()calls with.raise()on D3 selectionsBenefits
.raise()method for z-order management.raise()internally performs the same operationTesting
✅ All 233 tests pass (43 test files)
✅ TypeScript type checking passes
✅ Lint and format checks pass
Test plan
npm test🤖 Generated with Claude Code