fix(browser): register event loop on worker thread for stream_async#509
Open
wangwangbobo wants to merge 1 commit into
Open
fix(browser): register event loop on worker thread for stream_async#509wangwangbobo wants to merge 1 commit into
wangwangbobo wants to merge 1 commit into
Conversation
When strands dispatches _execute_async to a worker thread, the browser's event loop isn't available there, causing 'RuntimeError: There is no current event loop in thread'. Fix by calling asyncio.set_event_loop() in _execute_async before nest_asyncio.apply(). Fixes strands-agents#453
wangwangbobo
requested a deployment
to
manual-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #453
When strands dispatches
_execute_asyncto a worker thread, the browser's event loop isn't available there, causingRuntimeError: There is no current event loop in thread.Root cause:
Browser.__init__creates an event loop on the main thread_execute_asyncis a sync method, so strands dispatches it to a worker threadself._loop.run_until_complete()failsFix: Add
asyncio.set_event_loop(self._loop)at the start of_execute_asyncso the browser's loop is registered on whatever thread runs the tool.Changes: 1 file, +4 lines (≤10 line fix)