fix(litellm): generate toolUseId when missing from provider#1262
Closed
Ratish1 wants to merge 2 commits into
Closed
fix(litellm): generate toolUseId when missing from provider#1262Ratish1 wants to merge 2 commits into
Ratish1 wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
Thank you for the fix, @Ratish1, do you happen to have a code snippet or script that you used to verify and test this that a unique ID is being generated? |
Contributor
Author
Hello @mehtarac , I wrote a unit test for this by mocking in this PR, is that enough?. Or should I do a script with the same mocking and like a model_id. Thanks |
Contributor
Author
|
Hey @mehtarac , I'd like to follow up on my message in case you missed it. Thanks |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LiteLLM returns null for the tool call id field, causing toolUseId to be None in the resulting event stream. This PR ensures that a valid UUID is generated and assigned to the tool call delta if the provider returns a missing or null ID.Changes:
Related Issues
Fixes #1259
Documentation PR
N/AType of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.