Repository navigation
lvm: Deduplicate LVs by VG+LV name, not LV name alone - #1230
Merged
vojtechtrefny merged 1 commit intoNov 19, 2026
Merged
vojtechtrefny merged 1 commit into
vojtechtrefny merged 1 commit into
Conversation
bd_lvm_lvs skipped multi-segment duplicates using only lv_name, which dropped same-named LVs from different VGs. Blivet then KeyErrors looking up thin pools such as vgold-tpool0 during Anaconda storage discovery. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
vojtechtrefny
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bd_lvm_lvsskipped multi-segment duplicates using onlylv_name, which also dropped same-named LVs from different VGs.vgold-tpool0) when two VGs share pool/LV names.vg_nameandlv_namematch.Test plan
test_lvs_same_name_different_vgslibbd_lvm→KeyError: 'vgold-tpool0'; patched →Blivet().reset()succeeds with both VGs’ thin pools presentRelated
Made with Cursor