Skip to content

lvm: Deduplicate LVs by VG+LV name, not LV name alone - #1230

Merged
vojtechtrefny merged 1 commit into
storaged-project:2.x-branchfrom
Vaibhavbhope:fix/bd-lvm-lvs-cross-vg-dedup-2.x
Nov 19, 2026
Merged

vojtechtrefny merged 1 commit into
storaged-project:2.x-branchfrom
Vaibhavbhope:fix/bd-lvm-lvs-cross-vg-dedup-2.x

Conversation

@Vaibhavbhope

Copy link
Copy Markdown

Summary

  • Backport of lvm: Deduplicate LVs by VG+LV name, not LV name alone #1229 for the 2.x CLI LVM plugin.
  • bd_lvm_lvs skipped multi-segment duplicates using only lv_name, which also dropped same-named LVs from different VGs.
  • Blivet/Anaconda then KeyErrors on thin-pool lookup (e.g. vgold-tpool0) when two VGs share pool/LV names.
  • Deduplicate only when both vg_name and lv_name match.

Test plan

  • Added test_lvs_same_name_different_vgs
  • Upstream CI
  • Verified on patched RHEL 8.10 and RHEL 9.9 boot ISOs: stock libbd_lvm → KeyError: 'vgold-tpool0'; patched → Blivet().reset() succeeds with both VGs’ thin pools present

Related

Made with Cursor

bd_lvm_lvs skipped multi-segment duplicates using only lv_name, which
dropped same-named LVs from different VGs. Blivet then KeyErrors looking
up thin pools such as vgold-tpool0 during Anaconda storage discovery.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Nov 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f1b38759-8c67-483c-af75-e0be566afb3e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@vojtechtrefny
vojtechtrefny merged commit 25d44dc into storaged-project:2.x-branch Nov 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants