Skip to content

2.0.1 - #43

Merged
AussieScorcher merged 1 commit into
mainfrom
v2.0.1
Oct 3, 2026
Merged

AussieScorcher merged 1 commit into
mainfrom
v2.0.1

Conversation

@AussieScorcher

@AussieScorcher AussieScorcher commented Sep 20, 2026 •

Copy link
Copy Markdown
Member

Summary

Fix v2.0.1 issues affecting airport detection, server connectivity, X-Plane removals, debug mode and client notifications.

Changes Made

  • Fixed regional number formatting causing airport lookup failures and preventing server connections.
  • Added geometry-based X-Plane removal matching with a 10 cm tolerance and compatible light-property checks.
  • Fixed removal warnings when X-Plane is absent and improved recovery from stale patch history.
  • Fixed X-Plane debug state cycling and persistent MSFS restart reminders.
  • Replaced startup.log with dated, rotating client logs and clearer diagnostics.
  • Slightly increased window height to fit seven airport rows without changing row height.

Author Information

VATSIM CID: 1658308


Checklist:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

if (index >= count) throw new InvalidDataException("DSF point run exceeds its pool.");
if ((encoding & 1) != 0) value = (value + previous) & 65535;
previous = value;
points[index++][plane] = scale == 0 ? value : (value * (double)scale) / 65535 + offset;
string NumberHex(double value)
{
var bytes = new byte[8];
System.Buffers.Binary.BinaryPrimitives.WriteDoubleLittleEndian(bytes, value == 0 ? 0 : value);
Comment thread App.xaml.cs
{
try { await _mainWindowViewModel.PrepareForShutdownAsync(); }
catch (Exception ex) { StartupTrace.Write($"Active-mode shutdown cleanup failed: {ex.Message}"); }
catch (Exception ex) { ClientLog.Write($"Active-mode shutdown cleanup failed: {ex.Message}"); }
Comment thread App.xaml.cs
try { await _removalsUpdateTask; }
catch (OperationCanceledException) { }
catch (Exception ex) { StartupTrace.Write($"Removals update shutdown error: {ex.Message}"); }
catch (Exception ex) { ClientLog.Write($"Removals update shutdown error: {ex.Message}"); }
Comment on lines +70 to +73
catch
{
// Logging must not interrupt simulator or scenery operations.
}
private void RaiseDebugModeChanged(DebugModeChangedEventArgs change)
{
try { DebugModeChanged?.Invoke(this, change); }
catch (Exception ex) { _logger.LogDebug(ex, "X-Plane debug event handler failed"); }
{
try { SceneryService.Instance.SetSelectedPackage(airport.ICAO, configuredSim, match.Name); }
catch (Exception ex) { StartupTrace.Write($"SceneryService.SetSelectedPackage error: {ex.Message}"); }
catch (Exception ex) { ClientLog.Write($"SceneryService.SetSelectedPackage error: {ex.Message}"); }
{
try { SceneryService.Instance.SetSelectedPackage(airport.ICAO, configuredSim, defaultPackage.Name); }
catch (Exception ex) { StartupTrace.Write($"SceneryService.SetSelectedPackage error: {ex.Message}"); }
catch (Exception ex) { ClientLog.Write($"SceneryService.SetSelectedPackage error: {ex.Message}"); }
Comment on lines +1219 to +1223
catch (Exception ex)
{
ClientLog.Write($"MSFS removal startup sync failed: {ex}");
RunOnDispatcher(() => { Status = $"Could not sync MSFS removals: {ex.Message}"; LogLines.Add(Status); });
}
@greptile-apps

greptile-apps Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

The PR is not safe to merge until compressed X-Plane DSF removals can be patched successfully.

Findings

  1. P1 Compressed DSF Patching Fails ▶
Fix with agent prompt
### Issue 1
Infrastructure/Simulators/XPlane/XPlaneDsfPatcher.cs:210-213
For a supported 7z-compressed DSF, selector resolution decodes the file and stamps candidates with the decoded buffer's SHA-256. `Patch` then validates those selectors against the original compressed bytes, so the hashes differ and it throws “DSF source changed.” As a result, removals cannot be applied to compressed DSF files.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

This release fixes culture-sensitive airport lookup, expands X-Plane removal matching and recovery, adds simulator-specific debug behavior, improves restart notifications, and introduces rotating diagnostic logs.

  • Adds geometry-based apt.dat and DSF selector resolution with bundled reference metadata.
  • Separates MSFS and X-Plane removal synchronization and retry behavior.
  • Routes debug mode through the active simulator controller.
  • Adds invariant coordinate formatting, process-session restart tracking, and rotating client logs.
  • One blocking issue remains for compressed X-Plane DSF files.

Reviews (1) · Last reviewed commit: "Fix v2.0.1 simulator connections, remova..."

Comment on lines +210 to +213
var decoded = Decode(bytes);
List<GeometryCandidate> candidates = [];
List<string> comments = [];
Process(decoded, [], candidates, comments, selectors.Select(selector => selector.Definition).ToHashSet(StringComparer.Ordinal));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Compressed DSF Patching Fails

For a supported 7z-compressed DSF, selector resolution decodes the file and stamps candidates with the decoded buffer's SHA-256. Patch then validates those selectors against the original compressed bytes, so the hashes differ and it throws “DSF source changed.” As a result, removals cannot be applied to compressed DSF files.

Prompt To Fix With AI
This is a comment left during a code review.
Path: Infrastructure/Simulators/XPlane/XPlaneDsfPatcher.cs
Line: 210-213

Comment:
**Compressed DSF Patching Fails**

For a supported 7z-compressed DSF, selector resolution decodes the file and stamps candidates with the decoded buffer's SHA-256. `Patch` then validates those selectors against the original compressed bytes, so the hashes differ and it throws “DSF source changed.” As a result, removals cannot be applied to compressed DSF files.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

@AussieScorcher
AussieScorcher merged commit e754c5e into main Oct 3, 2026
6 checks passed
@AussieScorcher
AussieScorcher deleted the v2.0.1 branch October 3, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant