Skip to content

Fix anonymous analytics and remove API request tracking - #107

Merged
AussieScorcher merged 1 commit into
mainfrom
fix/anonymous-analytics
Oct 3, 2026
Merged

AussieScorcher merged 1 commit into
mainfrom
fix/anonymous-analytics

Conversation

@AussieScorcher

@AussieScorcher AussieScorcher commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Summary

Remove request-wide tracking and keep PostHog events anonymous.

Changes Made

  • Remove the API Request event.
  • Disable person-profile processing and reuse one background dispatch task.

Author Information

VATSIM CID: 1658308


Checklist:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@greptile-apps

greptile-apps Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[Medium risk] Removes API request tracking and adjusts analytics configuration.

The PR appears safe to merge; the remaining feedback is non-blocking test coverage for anonymous capture payloads.

Findings

  1. P2 Anonymous payloads lack test coverage ▶
Fix with agent prompt
### Issue 1
src/services/posthog.ts:104
This flag now reaches both `track` and `trackBatch` through `prepareProperties`, but no automated test checks that it appears inside each event’s properties. A later change could silently drop the flag from either capture path. A focused payload test would protect this non-blocking risk.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The PR removes request-wide API Request tracking and changes PostHog capture to set the anonymous-profile flag in event properties while reusing one background task.

  • Focused payload tests would protect the anonymity change across both capture paths.

Reviews (1) · Last reviewed commit: "fix: preserve local anonymous analytics ..."

Comment thread src/services/posthog.ts Resolved
@AussieScorcher
AussieScorcher merged commit 3e591e9 into main Oct 3, 2026
6 checks passed
@AussieScorcher
AussieScorcher deleted the fix/anonymous-analytics branch October 3, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant