Added Temperature, Humidity & Contact Sensor Post/Call Back to SmartThings#207
Open
JZ-SmartThings wants to merge 3 commits into
Open
Added Temperature, Humidity & Contact Sensor Post/Call Back to SmartThings#207JZ-SmartThings wants to merge 3 commits into
JZ-SmartThings wants to merge 3 commits into
Conversation
|
Thanks for this, I needed it!!! I had to make a small change, not sure if it is a bug or not, but the code assumes the temperature is an int and at line 775 in the smartapp you have 'device.setTemperature(value as int), I simply replaced this with 'device.setTemperature(value)' Thanks again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added Temperature, Humidity & Contact Sensor Post Back to SmartThings. Otherwise I had to use lame workarounds (like syncing with a switch). Modifying the SmartApp was so much simpler than any other solution. 10 lines of code but world of difference with these 3 capabilities and their read-only limitations in SmartThings.
Ultimately, being able to post these back to ST were big missing pieces for me. @stjohnjohnson I'd appreciate my enhancement pull becoming part of your release and respect your work very much! As an FYI, most of my code is a subset of pull #194 + a few more lines. However, the pull is just more narrow is scope and thus less code to verify. @gandazgul thanks for that pull.