Control over Fortran file extensions recognised by ModuleManager#3469
Open
mn416 wants to merge 4 commits into
Open
Control over Fortran file extensions recognised by ModuleManager#3469mn416 wants to merge 4 commits into
ModuleManager#3469mn416 wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3469 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 395 395
Lines 55199 55228 +29
=========================================
+ Hits 55199 55228 +29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic stuff, but I started using PSyclone in a code base with
.f95files and wondered why imports were not getting resolved. Turns out thatModuleManagerhas a limited set of harded coded file extensions that doesn't include.f95so this PR adds the ability to add/remove Fortran file extensions recognised byModuleManager. It also abstracts out a commonly used "doesn't need preprocessing" check into a method, which makes the code a bit cleaner.Edit: I believe these changes preserve existing behaviour exactly; they just introduce methods to allow modification of the default settings.