3461 duplicated script names#3468
Conversation
|
I've fixed the unit test failures by slightly changing the test (instead of setting sys.path, I We do get additional failure in example, since without modifying sys.path, helper scripts in the same directory as the psyclone scripts are NOT found anymore (unless you set |
…orting helper scripts, but clean up sys.pathin the end.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## master #3468 +/- ##
===========================================
- Coverage 100.00% 99.99% -0.01%
===========================================
Files 395 395
Lines 55199 55205 +6
===========================================
+ Hits 55199 55204 +5
- Misses 0 1 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Failures in one example and nemo (lfric is fine) indicate that we should modify sys.path when importing and executing a script (so that helper scripts in the same directory as the script are found). That was done in ab86dd3, so once I've updated the documentation this should be ready to go. |
Fixes #3461.